Toyota Repair: No cranking on 92 Toyota p/u 4 cycl., filter hose, coil ignition

Question
I've been having this problem all year. Sometimes there is no cranking by the starter as I turn the key. Basically, nothing happens. Then, it will crank/turnover and run fine; continuing to crank/start normally for a few times or even days. I've only recently heard a loud clicking sometimes as I turn the key (the times when nothing happens). I've changed all my plug leads, rotor/cap and coil wires, and recharged the battery.
Ids the following a clue, maybe?...
The beeping to indicate my key is in the ignition/power on position & when the door is open continues to sound sometimes even w/out the key in the ignition. Is this the sign of a short, and the possible cause? My mechanic recently couldn't diagnosis another problem (disconeccted plastic air filter hose!!!)and when I explaind what happened, then asked if he'd consider this when I brought the truck in said the no cranking was a bad starter w/out doing any diagnosis (he also did not offer a refund of any kind on the previous job which is another story).
What next to rule out any other causes? Coil, ignition, etc? Thank  you.

Answer
Dan,
First thing to do is check the connections on the battery for tightness and clean. If your sure its ok then its most likely the
starter. When it won't turn over have someone hold the key on while
you tap on the starter with a hammer a few times. If it starts then, time to replace the starter.