Motorcycle Repair: 1975 shovalhead oil pump, spring roller, oil tank

Question
I was riding the bike I heard a spinning sound moments later it started knocking. Oil level high in oil tank. Have taken oil pump apart no visual problems.  

Answer
Did you know if you had oil pressure before you took it apart?
Your knocking could be several things. Broken valve spring, roller gone bad that rides the cam, bent rod, hydrolic lifter gone bad to name a few.
Put the oil pump back together and install. Check the pushrods to see if any has collasped. If not then start the bike and make sure you have pressure. If you do then your going to have to start tearing it down from the top end until you find the problem.
Good luck and happy riding
Mike